Save work on emitting ignored diagnostics pt 2#20696
Merged
JukkaL merged 1 commit intopython:masterfrom Jan 30, 2026
Merged
Conversation
This should be another 2.5% on self check
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Jan 30, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Nice, I guess this helps with third-party libraries a lot.
cdce8p
added a commit
to cdce8p/mypy
that referenced
this pull request
Feb 1, 2026
Collaborator
|
This change causes a few regressions for Home Assistant. As an example, one can be narrowed down to # pip install voluptuous==0.16.0
import voluptuous as vol
def f(ex: vol.MultipleInvalid):
reveal_type(ex.errors)This should be inferred as The classes are basically defined as: class Invalid(Exception): ...
class MultipleInvalid(Invalid):
def __init__(self, errors: list[Invalid] | None = None) -> None:
self.errors = errors[:] if errors else []However, with that -- |
Collaborator
Author
|
Ah, I see the issue. This is why I had the "pure" renames in the first PR. I'll revert and think about if there's a good way to be systematic about this. Thanks for bringing it up! |
hauntsaninja
added a commit
that referenced
this pull request
Feb 1, 2026
This reverts commit 195ab98.
hauntsaninja
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be another 2.5% on self check
Sequel to #20621